Skip to content

fix(web): remove v prefix from version in page title#744

Merged
avivkeller merged 1 commit intonodejs:mainfrom
sujalgoel:fix/version-header-v-prefix
Apr 6, 2026
Merged

fix(web): remove v prefix from version in page title#744
avivkeller merged 1 commit intonodejs:mainfrom
sujalgoel:fix/version-header-v-prefix

Conversation

@sujalgoel
Copy link
Copy Markdown
Contributor

The page title currently renders as "Node.js v25.4.0 Documentation". The Node.js documentation style guide specifies that version references should not include the v prefix.

Removes the v from the template string in processJSXEntries so the title renders as "Node.js 25.4.0 Documentation".

Fixes #722

@sujalgoel sujalgoel requested a review from a team as a code owner April 2, 2026 14:36
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Apr 6, 2026 3:28pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.42%. Comparing base (ba9ca89) to head (2dff824).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files         157      157           
  Lines       13959    13959           
  Branches     1152     1152           
=======================================
  Hits        10948    10948           
  Misses       3006     3006           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
Copy link
Copy Markdown

It would be nice to see this fixed! I didn't attempt to submit any PR myself for this issue because I assumed that the new website format (see nodejs/node#52343) would be promoted to production much sooner.

MikeMcC399

This comment was marked as resolved.

MikeMcC399

This comment was marked as outdated.

@sujalgoel
Copy link
Copy Markdown
Contributor Author

Thanks for the context. The fix still makes sense regardless of the UI format since it removes the hardcoded v prefix and moves the title string into defaultConfiguration where it can be overridden per project. Happy to defer to the maintainers on whether to merge.

@avivkeller
Copy link
Copy Markdown
Member

Yes, this should be merged (after our 48hr review time)

@MikeMcC399
Copy link
Copy Markdown

There are conflicts again, so these would need resolving before a merge would be possible.

@sujalgoel sujalgoel force-pushed the fix/version-header-v-prefix branch from f27f242 to 2dff824 Compare April 6, 2026 15:27
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 6, 2026

PR Summary

Low Risk
Low risk: changes only the default web page title template string and does not affect data handling or execution flow.

Overview
Updates the web generator’s default title template to drop the v prefix before {version}, so rendered documentation page titles show Node.js 25.4.0 Documentation instead of Node.js v25.4.0 Documentation.

Reviewed by Cursor Bugbot for commit 2dff824. Bugbot is set up for automated code reviews on this repo. Configure here.

@avivkeller avivkeller merged commit b2330d9 into nodejs:main Apr 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API docs version header uses v version prefix

5 participants