fix(web): remove v prefix from version in page title#744
fix(web): remove v prefix from version in page title#744avivkeller merged 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage 78.42% 78.42%
=======================================
Files 157 157
Lines 13959 13959
Branches 1152 1152
=======================================
Hits 10948 10948
Misses 3006 3006
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It would be nice to see this fixed! I didn't attempt to submit any PR myself for this issue because I assumed that the new website format (see nodejs/node#52343) would be promoted to production much sooner. |
8c7af7a to
f27f242
Compare
|
Thanks for the context. The fix still makes sense regardless of the UI format since it removes the hardcoded v prefix and moves the title string into defaultConfiguration where it can be overridden per project. Happy to defer to the maintainers on whether to merge. |
|
Yes, this should be merged (after our 48hr review time) |
|
There are conflicts again, so these would need resolving before a merge would be possible. |
f27f242 to
2dff824
Compare
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 2dff824. Bugbot is set up for automated code reviews on this repo. Configure here. |
The page title currently renders as "Node.js v25.4.0 Documentation". The Node.js documentation style guide specifies that version references should not include the
vprefix.Removes the
vfrom the template string inprocessJSXEntriesso the title renders as "Node.js 25.4.0 Documentation".Fixes #722